-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Replace matplotlib seaborn style plots with Arviz Plots in Documentation (WIP) #4560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4560 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 89 89
Lines 14637 14637
=======================================
Hits 12887 12887
Misses 1750 1750
|
Due to the merge from the other PR this one should be rebased on top of the github master branch. I know thats a lot of obscure git works so let me know if what I said meant anything to you and you want extra explanation |
okay yeah i tried git checkout my branch and then git rebase master which showed up-to-date and then i tried fetching upstream again, should i just make an optional comment as a commit to see if its fine now? I'm not entirely sure of what happened i'll be honest |
@canyon289 Okay I'm sorry I think i messed up the whole thing lol I'm so confused, should i just close this PR and start over? |
@almostmeenal no problem, its very easy to get tripped up by merging and rebasing. If it's easier for you to just start a new PR using the current master, then feel free to do so. I've used that solution many times. Whatever makes your life easier. |
thanks a ton, that was relieving
…On 23 Mar 2021, 9:59 PM +0530, Chris Fonnesbeck ***@***.***>, wrote:
@almostmeenal no problem, its very easy to get tripped up by merging and rebasing. If it's easier for you to just start a new PR using the current master, then feel free to do so. I've used that solution many times. Whatever makes your life easier.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
While working on issue 3859 , we saw seaborn-darkgrid is not the best of color friendly styles, and seaborn-colorblind is not regularly updated. arviz-darkgrid is relatively better and additionally as @ OriolAbril pointed out - matplotlib styles have not been updated in ~5 years, so using ArviZ would give us better control and the ability to easily update the style if needed.
This PR changes plt.style.use("seaborn-darkgrid") to arviz-darkgrid and adds a line of importing arviz, which is anyway a pymc3 dependency.
These changes are in continuous.py and discrete.py (i.e. The sample plots in documentation)