Skip to content

Updated the documentation for the fastfn function with default argume… #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Updated the documentation for the fastfn function with default argume… #4651

merged 1 commit into from
Jun 5, 2021

Conversation

Swanand01
Copy link
Contributor

@Swanand01 Swanand01 commented Apr 19, 2021

Updated the doctstrings of the fastfn() function in the model.py file to include the missing argument and the default values.
Also replaced **kargs with **kwargs in the model.py file

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

Closes #4630

@michaelosthege
Copy link
Member

Hi @Swanand01 ,
it looks like your PR goes into master and it changes code that, if I'm not mistaken, is heavily refactored on the v4 branch.
Because we want to merge v4 into master, we have frozen PRs into master for the time being. Also see https://github.com/pymc-devs/pymc3/wiki/Timeline about this.
If the problem you want to address still exists on the v4 branch we'll be happy to take a PR there.

@michaelosthege michaelosthege merged commit 84110de into pymc-devs:main Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change **kargs to **kwargs
2 participants