Fixed bug in delta_logp for MLDA that broke AEM and VR #5104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5099
The bug was caused by the now deprecated function
delta_logp_inverse
not evaluating the proposal last, which was the sole intention with that function. The functionality has now been replaced bylambda
-function for the base sampler when using VR, where additional information is collected from the base model.q
andq0
and the sign ofdelta_logp
for the finer sampling levels.