Fix Poisson logcdf #5307
Merged
Fix Poisson logcdf #5307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #5307 +/- ##
==========================================
+ Coverage 79.01% 79.03% +0.02%
==========================================
Files 87 87
Lines 14370 14370
==========================================
+ Hits 11354 11357 +3
+ Misses 3016 3013 -3
|
canyon289
reviewed
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up in #5231, the evalution of a scalar logcdf was returning a 1D result, because of a silly comma :D
Didn't add tests, because we are not checking this for any other distribution...