introduced tests for pymc.distributions.logprob._get_scaling_ #5544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5544 +/- ##
==========================================
- Coverage 89.21% 86.66% -2.56%
==========================================
Files 75 75
Lines 13846 13846
==========================================
- Hits 12353 11999 -354
- Misses 1493 1847 +354
|
|
@ricardoV94 @chritter can you check/fix/apply the suggestions I commented? Let's get this over the finish line |
michaelosthege
approved these changes
May 8, 2022
pymc/tests/test_logprob.py
Outdated
|
|
||
| # list or tuple tests | ||
| # total_size contains other than Ellipsis, None and Int | ||
| with pytest.raises(TypeError): |
There was a problem hiding this comment.
Suggested change
| with pytest.raises(TypeError): | |
| with pytest.raises(TypeError, match="expected int or list of ints"): |
pymc/tests/test_logprob.py
Outdated
Comment on lines
56
to
70
| with pytest.raises(ValueError): | ||
| _get_scaling([1, 2, 5, Ellipsis, Ellipsis], (2, 3), 2) | ||
| with pytest.raises(ValueError): | ||
| _get_scaling([1, 2, 5, Ellipsis], (2, 3), 2) |
There was a problem hiding this comment.
Suggested change
| with pytest.raises(ValueError): | |
| _get_scaling([1, 2, 5, Ellipsis, Ellipsis], (2, 3), 2) | |
| with pytest.raises(ValueError): | |
| _get_scaling([1, 2, 5, Ellipsis], (2, 3), 2) | |
| with pytest.raises(ValueError, match="Double Ellipsis"): | |
| _get_scaling([1, 2, 5, Ellipsis, Ellipsis], (2, 3), 2) | |
| with pytest.raises(ValueError, match="scalings is bigger that ndim"): | |
| _get_scaling([1, 2, 5, Ellipsis], (2, 3), 2) |
pymc/tests/test_logprob.py
Outdated
| assert _get_scaling([4, 5, 9, Ellipsis, 32, 12], (2, 3, 2), 5).eval() == 960 | ||
| assert _get_scaling([4, 5, 9, Ellipsis], (2, 3, 2), 5).eval() == 15 | ||
| # total_size with no Ellipsis (end = [ ]) | ||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
Suggested change
| with pytest.raises(ValueError): | |
| with pytest.raises(ValueError, match="scalings is bigger that ndim"): |
pymc/tests/test_logprob.py
Outdated
| assert _get_scaling([], (2, 3), 2).eval() == 1 | ||
| assert _get_scaling((), (2, 3), 2).eval() == 1 | ||
| # total_size invalid type | ||
| with pytest.raises(TypeError): |
There was a problem hiding this comment.
Suggested change
| with pytest.raises(TypeError): | |
| with pytest.raises(TypeError, match="expected int or list of ints"): |
Co-authored-by: Icyshaman <[email protected]>
michaelosthege
force-pushed
the
_get_scaling_tests
branch
from
6660dd3 to
af2e5f9
Compare
michaelosthege
approved these changes
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5515. We have implemented tests for pymc.distributions.logprob.get_scaling which include edge cases and a test with a model graph random variable. Please let us know if the test coverage is sufficient or if further tests are required.
Co-authored-by: @Icyshaman.
Depending on what your PR does, here are a few things you might want to address in the description:
#DataUmbrella Sprint
@reshamas