-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Refactoring towards IBaseTrace
interfaces
#6475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michaelosthege
merged 4 commits into
pymc-devs:main
from
michaelosthege:trace-interfaces
Feb 3, 2023
Merged
Refactoring towards IBaseTrace
interfaces
#6475
michaelosthege
merged 4 commits into
pymc-devs:main
from
michaelosthege:trace-interfaces
Feb 3, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6475 +/- ##
==========================================
- Coverage 94.79% 94.79% -0.01%
==========================================
Files 148 148
Lines 27730 27745 +15
==========================================
+ Hits 26287 26301 +14
- Misses 1443 1444 +1
|
455f582
to
326a1bd
Compare
326a1bd
to
cb64941
Compare
ricardoV94
reviewed
Jan 26, 2023
aloctavodia
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to identify & specify the
BaseTrace
attributes & methods that are necessary from the perspectives of internal sampling functions (pm.sampling.mcmc.*
) andMultiTrace
.By extracting these signatures/interfaces into an abstract class
IBaseTrace
it becomes much easier to write a small adapter class that can wrap other kinds of backends to be used instead ofBaseTrace
. (hint hint 🍔)Checklist
Major / Breaking Changes
MultiTrace.straces
type changes fromSequence[BaseTrace]
toSequence[IBaseTrace]
Maintenance
weibull_logp
test