Skip to content

Fix bug when reusing jax logp for initial point generation #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 26, 2025

@ricardoV94 ricardoV94 merged commit 62335ac into pymc-devs:main Feb 26, 2025
22 checks passed
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (53e0774) to head (9ad9cf7).
Report is 63 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7695      +/-   ##
==========================================
+ Coverage   90.72%   92.64%   +1.92%     
==========================================
  Files         107      107              
  Lines       18324    18324              
==========================================
+ Hits        16625    16977     +352     
+ Misses       1699     1347     -352     
Files with missing lines Coverage Δ
pymc/sampling/jax.py 94.11% <100.00%> (-0.91%) ⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 deleted the jax_initial_point_bug branch February 26, 2025 13:31
@nataziel
Copy link
Contributor

Just for anyone investigating this later I think this was directly caused by #7610, not #7681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants