-
Notifications
You must be signed in to change notification settings - Fork 135
Slogdet returns naive expression and is optimized later #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ricardoV94
merged 16 commits into
pymc-devs:main
from
tanish1729:slogdet-generalisation
Nov 17, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bd1dbb1
Added alternative slogdet to return sign and logdet of det op
tanish1729 36ed084
removed rewrites for slogdet and added the same for det which will be…
tanish1729 7dee977
added specialised rewrite for slogdet
tanish1729 9ba4a9a
updated checks for specialised rewrite
tanish1729 51038ef
fixing bad rebase
tanish1729 fa4ed0b
updated specialisation rewrite
tanish1729 03215e8
working specialised rewrite + test
tanish1729 6927516
added all tests
tanish1729 8f6badf
splitting rewrite into 2 stages done
tanish1729 69765a1
fixed failing precision test
tanish1729 60e34fe
added missing function becaues of rebase
tanish1729 6e4f04b
minor changes
tanish1729 7a05cb1
check for pytorch failing test
tanish1729 7f179af
fixed mypy error and pytorch linking test
tanish1729 912eab4
forgot to add one small (major) change
tanish1729 398f4ad
fixed documentation
tanish1729 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.