-
Notifications
You must be signed in to change notification settings - Fork 130
Removes Function Graph, set_test_value/ get_test_value #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Function Graph, set_test_value/ get_test_value #1107
Conversation
@AdvH039 changes looks great. There are some conflicts that emerged since you opened the PR. If you can fix them we can merge. Optionally, but not a blocker, if you could put the I understand it's a lot of work, so feel free to decline |
@ricardoV94 Resolved conflicts and included changes as mentioned by you.
I want to decline and focus on other issues..😅 . I hope you don't mind. Thanks! |
7da339a
to
6225c08
Compare
7dbf73d
to
1baee1f
Compare
1baee1f
to
7117383
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
- Coverage 82.04% 82.03% -0.02%
==========================================
Files 188 188
Lines 48533 48535 +2
Branches 8675 8676 +1
==========================================
- Hits 39819 39814 -5
- Misses 6553 6558 +5
- Partials 2161 2163 +2
🚀 New features to boost your workflow:
|
Description
Removes the FunctionGraph mechanism of taking inputs and outputs and instead takes them directly in compare_py_and_x . Remove the setting getting of test_values into variables in compare_py_and_x and instead passes them directly to the function.
Related Issue
FunctionGraph
in linker tests #1022FunctionGraph
in linker tests #1022Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1107.org.readthedocs.build/en/1107/