Skip to content

Removes Function Graph, set_test_value/ get_test_value #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

AdvH039
Copy link
Contributor

@AdvH039 AdvH039 commented Nov 28, 2024

Description

Removes the FunctionGraph mechanism of taking inputs and outputs and instead takes them directly in compare_py_and_x . Remove the setting getting of test_values into variables in compare_py_and_x and instead passes them directly to the function.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1107.org.readthedocs.build/en/1107/

@ricardoV94
Copy link
Member

ricardoV94 commented Dec 3, 2024

@AdvH039 changes looks great. There are some conflicts that emerged since you opened the PR. If you can fix them we can merge. Optionally, but not a blocker, if you could put the test_values after the tensor inputs in the parametrize that would be a bit more readable. This would be everywhere, not just the 2/3 odd places I commented above

I understand it's a lot of work, so feel free to decline

@AdvH039
Copy link
Contributor Author

AdvH039 commented Dec 25, 2024

@ricardoV94 Resolved conflicts and included changes as mentioned by you.

@AdvH039 changes looks great. There are some conflicts that emerged since you opened the PR. If you can fix them we can merge. Optionally, but not a blocker, if you could put the test_values after the tensor inputs in the parametrize that would be a bit more readable. This would be everywhere, not just the 2/3 odd places I commented above

I understand it's a lot of work, so feel free to decline

I want to decline and focus on other issues..😅 . I hope you don't mind. Thanks!

@ricardoV94 ricardoV94 force-pushed the remove_FunctionGraph_linker_tests branch from 7da339a to 6225c08 Compare January 30, 2025 12:09
@ricardoV94 ricardoV94 force-pushed the remove_FunctionGraph_linker_tests branch 6 times, most recently from 7dbf73d to 1baee1f Compare February 17, 2025 16:34
@ricardoV94 ricardoV94 force-pushed the remove_FunctionGraph_linker_tests branch from 1baee1f to 7117383 Compare February 18, 2025 09:12
@ricardoV94 ricardoV94 added bug Something isn't working numba labels Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.03%. Comparing base (51ea1a0) to head (7117383).
Report is 144 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/link/numba/dispatch/slinalg.py 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   82.04%   82.03%   -0.02%     
==========================================
  Files         188      188              
  Lines       48533    48535       +2     
  Branches     8675     8676       +1     
==========================================
- Hits        39819    39814       -5     
- Misses       6553     6558       +5     
- Partials     2161     2163       +2     
Files with missing lines Coverage Δ
pytensor/link/numba/dispatch/slinalg.py 44.60% <0.00%> (-0.17%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit e25e8a2 into pymc-devs:main Feb 18, 2025
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't create useless FunctionGraph in linker tests
2 participants