-
Notifications
You must be signed in to change notification settings - Fork 135
Speedup scalar Op python implementations #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f8abadb
to
866f488
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
- Coverage 82.27% 82.26% -0.01%
==========================================
Files 186 186
Lines 48066 47962 -104
Branches 8633 8630 -3
==========================================
- Hits 39546 39456 -90
+ Misses 6360 6347 -13
+ Partials 2160 2159 -1
🚀 New features to boost your workflow:
|
Looks good, but there are two more |
definitely, missed those |
289067c
to
e4547cd
Compare
e4547cd
to
5ca1724
Compare
I removed the Chi2SF Scalar Op altogether. There is a tensor helper that still works with a future warning to just use gammaincc instead. This is not a standard scipy special function, and it doesn't make sense to support a redundant Op. It didn't even have gradients, where gammaincc does. |
5ca1724
to
5d340e2
Compare
Some cleanup of unused code in scalar/math.py.
Also speedup a bit the perform method by avoiding allocating intermediate variables and attribute acces for a helper function
📚 Documentation preview 📚: https://pytensor--1169.org.readthedocs.build/en/1169/