Remove Unbroadcast Op
#1286
Merged
Remove Unbroadcast Op
#1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
added
bug
ricardoV94
force-pushed
the
remove_unbroadcast
branch
8 times, most recently
from
a42d1eb to
5b486cc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
- Coverage 82.03% 82.01% -0.02%
==========================================
Files 188 188
Lines 48567 48442 -125
Branches 8675 8659 -16
==========================================
- Hits 39841 39730 -111
+ Misses 6574 6566 -8
+ Partials 2152 2146 -6
🚀 New features to boost your workflow:
|
jessegrabowski
approved these changes
Mar 14, 2025
| else: | ||
| # FIXME: This is never used | ||
| nw_input = nw_inputs[in_idx][: (initl + nw_steps)] | ||
| # Number of steps in the initial state |
There was a problem hiding this comment.
is that FIXME in the old code still relevant?
There was a problem hiding this comment.
Fixed with these changes
ricardoV94
force-pushed
the
remove_unbroadcast
branch
from
5b486cc to
ad9f405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1281, remove weird Op that was only used in Scan graphs. Removing revealed a bug in the scan save memory that I attempted to fix a while ago in #236
📚 Documentation preview 📚: https://pytensor--1286.org.readthedocs.build/en/1286/