Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shell=False for Popen on Windows #1324

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Mar 27, 2025

Description

I'm having hard times creating new environments with working compiler dependencies.

My debugging attempts show that shell=False could fix this, however this observation contradicts the comments next to that line.
Further testing may be required.

Related Issue

Hints?

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1324.org.readthedocs.build/en/1324/

@michaelosthege michaelosthege added bug Something isn't working C-backend labels Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.98%. Comparing base (a038c8e) to head (1c15c12).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1324   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files         198      198           
  Lines       48713    48713           
  Branches     8682     8682           
=======================================
  Hits        39937    39937           
  Misses       6625     6625           
  Partials     2151     2151           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelosthege
Copy link
Member Author

@Armavica you also worked on these components - what do you think about shell=False? Does it work on your machine?

@Armavica
Copy link
Member

I will have a look this weekend or next week

@michaelosthege
Copy link
Member Author

I will have a look this weekend or next week

@Armavica did you already get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C-backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants