Don't run local uint constant indices in C/Python backends #1335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization is actually a slow down, because the implementations always requset a cast of indices to intp. We used to do it explicitly in
AdvancedSubtensor1
but the underlying numpy C function also does it: https://github.com/numpy/numpy/blob/c23886c226012a50da11066d3be98fd94e571101/numpy/_core/src/multiarray/item_selection.c#L247-L251Local benchmark on a PyMC model that uses AdavncedSubtensor1/Inc shows a slowdown compared to when the optimization is not used.
This PR removes the rewrite from these backends. It also makes the rewrite apply only after
specialization
to avoid too many passes when other rewrites introduce things likex.shape[i]
which will be removed anyway.📚 Documentation preview 📚: https://pytensor--1335.org.readthedocs.build/en/1335/