Propagate static output shapes in Split and avoid copy in C-impl #1343
+99
−121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Split (which shows up in the gradient of Join) much faster as it doesn't do useless copies.
I see a speedup of ~10x, obviously the comparison would scale with the ammount of copying that is now avoided
Also added static output shape and cleanup other methods of Split
📚 Documentation preview 📚: https://pytensor--1343.org.readthedocs.build/en/1343/