Skip to content

Use PyObject_CallNoArgs to call thunks from VM #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Apr 29, 2025

This is part of the Python ABI since 3.9. It saves a tiny ~20ns per thunk call, but costs us nothing :).


📚 Documentation preview 📚: https://pytensor--1383.org.readthedocs.build/en/1383/

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (4378d48) to head (e5b15b6).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1383   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files         207      207           
  Lines       49250    49250           
  Branches     8734     8734           
=======================================
  Hits        40394    40394           
  Misses       6692     6692           
  Partials     2164     2164           
Files with missing lines Coverage Δ
pytensor/link/c/lazylinker_c.py 75.30% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the speedup! 😀

@michaelosthege michaelosthege merged commit a2b7985 into pymc-devs:main Apr 29, 2025
74 checks passed
@ricardoV94 ricardoV94 deleted the use_PyObject_CallNoArgs branch April 29, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants