-
Notifications
You must be signed in to change notification settings - Fork 129
Fix import errors if setuptools is too old #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,29 @@ | ||
from setuptools.errors import CompileError as BaseCompileError | ||
try: | ||
from setuptools.errors import CompileError as BaseCompileError | ||
except ImportError: | ||
import warnings | ||
from distutils.errors import CompileError as BaseCompileError # type: ignore | ||
from importlib.metadata import version | ||
|
||
# These exception classes were made available in setuptools | ||
# since v59.0.0 via <https://github.com/pypa/setuptools/pull/2858> | ||
# in preparation for distutils deprecation. Complain loudly if they | ||
# are not available. | ||
setuptools_version = version("setuptools") | ||
warnings.warn( | ||
f"You appear to be using an ancient version of setuptools: " | ||
f"v{setuptools_version}. Please upgrade to at least v59.0.0. " | ||
f"Support for this version of setuptools is provisionary and " | ||
f"may be removed without warning in the future." | ||
) | ||
|
||
class MissingGXX(Exception): | ||
""" | ||
This error is raised when we try to generate c code, | ||
but g++ is not available. | ||
|
||
""" | ||
class MissingGXX(Exception): | ||
"""This error is raised when we try to generate c code, but g++ is not available.""" | ||
|
||
|
||
class CompileError(BaseCompileError): | ||
"""This custom `Exception` prints compilation errors with their original | ||
formatting. | ||
""" | ||
class CompileError(BaseCompileError): # pyright: ignore | ||
"""Custom `Exception` prints compilation errors with their original formatting.""" | ||
|
||
def __str__(self): | ||
return self.args[0] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to instead add a warning here. I'm tracking down the various relevant setuptools versions to cite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ferrine, @twiecki, I added a warning. Does this look helpful?
I'm not sure what the dangling
warnings.warn(
is about, but I'm not sure we should care.