-
Notifications
You must be signed in to change notification settings - Fork 129
Handle windows conda library directories in default blas #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that failing test a bug uncovered by a change in the graph?
4410a6b
to
07fa4e5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
=======================================
Coverage 80.82% 80.82%
=======================================
Files 162 162
Lines 46189 46194 +5
Branches 11288 11290 +2
=======================================
+ Hits 37330 37335 +5
Misses 6633 6633
Partials 2226 2226
|
The failing test happened because there were empty |
Isn't it good that the test actually failed? |
Okay you changed the dprint one, that's fine |
The other failing test was caused by having one extra line in the print statement: the warning you get at import when no blas headers are available. That doesn’t seem to be a valid failure to me |
Just to be clear, this doesn’t close #508. That one looks more like a nixOS problem with libraries and I need more info to address it |
Yeah, I just wonder if we will be blind about regressions, not that this test should have that responsibility |
@michaelosthege can you locally try on your Windows machine?
|
environment was created by
followed by |
Closes #515
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance