-
Notifications
You must be signed in to change notification settings - Fork 264
docs: table and add stars #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@joerick If you like this, then I'll add scikit-learn, scikit-image (seems to have converted 7 days ago), google/neuroglancer, h5py, pyzmq, python-rapidjson, jq.py, the three pybind11 examples, and the Scikit-HEP repos. |
Would be great to add those extra repos you mentioned! scikit-learn is a big one, good job team! On the formatting, unfortunately HTML table formatting is crushing the stars column... I wonder if a more compact badge would solve that? I played around with shields.io and came up with this-
I might be going too far, but another thought would be to add a logo for the CI service they're using, like (for reference, available icons are listed here) |
I could also just put the stars with the name, instead of in a column, or I could do GH Stars for the title, which makes it a bit wider. I also considered putting a "Last updated" badge, which would help us clean up ones that are dead. The downside with adding CI logos is that we'd have to manually maintain that. I do like the idea of reducing the notes to 1 line, so maybe CI + OSs would make that really just a quick note. |
<!-- Matplotlib: 12714, last pushed 0 days ago -->
<!-- twisted-iocpsupport: 4099, last pushed 5 days ago -->
<!-- websockets: 3045, last pushed 3 days ago -->
<!-- aiortc: 2046, last pushed 2 days ago -->
<!-- coverage.py: 1420, last pushed 0 days ago -->
<!-- creme: 1153, last pushed 2 days ago -->
<!-- PyAV: 1105, last pushed 23 days ago -->
<!-- aioquic: 538, last pushed 30 days ago -->
<!-- AutoPy: 500, last pushed 86 days ago -->
<!-- pikepdf: 468, last pushed 3 days ago -->
<!-- Parselmouth: 423, last pushed 7 days ago -->
<!-- KDEpy: 223, last pushed 4 days ago -->
<!-- bx-python: 95, last pushed 67 days ago -->
<!-- pybase64: 51, last pushed 0 days ago -->
<!-- TgCrypto: 48, last pushed 17 days ago -->
<!-- etebase-py: 39, last pushed 3 days ago -->
<!-- gmic-py: 15, last pushed 0 days ago -->
<!-- fathon: 15, last pushed 41 days ago -->
<!-- pyinstrument_cext: 8, last pushed 9 days ago -->
<!-- python-admesh: 8, last pushed 893 days ago -->
<!-- xmlstarlet: 7, last pushed 10 days ago -->
<!-- apriltags2-ethz: 1, last pushed 567 days ago --> |
I'd also propose we remove |
Cool! Btw, I'm not sure it's worth depending on that, but I recently used PyGithub (to download artifacts from GitHub builds to ReadTheDocs), and I really liked it :-) So maybe you can loose a few manual API queries? |
(Somehow, the stars still get scaled, though?) |
Everything is scaled by the width of the column. Try editing the above post to add lots of The main point of stars was to sort this - now that we read the stars and sort it via the script, we could drop the stars. I think I'd only use PyGithub if the API limiting feature became an issue, since it allows you to log in more easily. |
0f049b1
to
177eb8e
Compare
New version. It can now embed the output in the readme for you, and it also uses PyGithub with optional authentication since I was running it too often. Adds the GitHub description (with a little book icon) if no description was given. PS: I missed a couple when checking CI & OS, will add next update - also didn't update ones that were already there, like twisted)
<!-- scikit-learn: 43276, last pushed 0 days ago -->
<!-- Matplotlib: 12714, last pushed 0 days ago -->
<!-- twisted-iocpsupport: 4100, last pushed 5 days ago -->
<!-- scikit-image: 4073, last pushed 0 days ago -->
<!-- websockets: 3047, last pushed 4 days ago -->
<!-- pyzmq: 2650, last pushed 1 days ago -->
<!-- aiortc: 2046, last pushed 2 days ago -->
<!-- h5py: 1450, last pushed 1 days ago -->
<!-- coverage.py: 1421, last pushed 0 days ago -->
<!-- creme: 1153, last pushed 3 days ago -->
<!-- PyAV: 1105, last pushed 23 days ago -->
<!-- google/neuroglancer: 545, last pushed 0 days ago -->
<!-- aioquic: 538, last pushed 30 days ago -->
<!-- AutoPy: 500, last pushed 86 days ago -->
<!-- pikepdf: 468, last pushed 3 days ago -->
<!-- Parselmouth: 423, last pushed 7 days ago -->
<!-- python-rapidjson: 405, last pushed 5 days ago -->
<!-- KDEpy: 224, last pushed 5 days ago -->
<!-- pybind11:python_example: 217, last pushed 25 days ago -->
<!-- pybind11:cmake_example: 214, last pushed 8 days ago -->
<!-- iminuit: 163, last pushed 0 days ago -->
<!-- jq.py: 137, last pushed 54 days ago -->
<!-- bx-python: 95, last pushed 68 days ago -->
<!-- boost-histogram: 60, last pushed 0 days ago -->
<!-- pybase64: 51, last pushed 0 days ago -->
<!-- TgCrypto: 48, last pushed 17 days ago -->
<!-- etebase-py: 39, last pushed 3 days ago -->
<!-- pyjet: 27, last pushed 10 days ago -->
<!-- numpythia: 23, last pushed 8 days ago -->
<!-- gmic-py: 15, last pushed 0 days ago -->
<!-- fathon: 15, last pushed 41 days ago -->
<!-- pyinstrument_cext: 8, last pushed 10 days ago -->
<!-- xmlstarlet: 7, last pushed 10 days ago -->
<!-- pybind11:scikit_build_example: 1, last pushed 23 days ago --> |
I haven't seen how this renders on RtD, maybe @joerick you could check that? By the way, why is the changelog stripped from read the docs? I missed it for a while because I didn't realize the RtD page and GitHub page were not the same (and the changelog is the most important part of the docs to me ;) ) |
This is looking quite good! And I love how it's automated. ✨ It's quite visually busy, maybe we don't need the stars column after all? And the book emoji is too loud. I'm happy to have a go at writing/copying something into the
RtD renders each PR as a 'check', you can see how it comes out - https://cibuildwheel--474.org.readthedocs.build/en/474/ - but the short answer is that it isn't included! Not all the README is included in that home page, just the introduction, which sets out what cibuildwheel does, before the docs head into the setup guide.
When this was set up the goal was mostly to just get an intro to the project into that first page of the docs, not to recreate the entire readme. But if you're saying that you miss that content in the docs site (and I do find it awkward to find the link to Github from the docs site), maybe we should add another page with changelog included. I'd only suggest that it was a separate page so that the first 'Home' page isn't too long. As for what we do about this table, I'm guessing you'd be in favour of including it? I think that makes sense too (1). It could be another page in the docs - "Working examples"/"Inside real projects"/"As seen in…"/"In the wild" (1): So far, I've always felt that the Github project is the 'home' of the project, and the docs is an external resource. But I think your angle seems to be that docs is the 'home'. And it does seem that most Python projects at some point make that switch, although personally I've always preferred going to Github to get README, issues, dip into code etc. What do you think? |
I also tend to take that stance, I think, but the most important point is that things are linked and you can easily go from one to the other. |
I think the docs site should be reasonably complete - a list of projects would be very useful on the docs site, and the list of changes would be nice too, though not as critical. The docs site has everything a user needs in one place - to me, this should always include the changelog. Ideally, there would be a changes or what's new page, and an example projects page. There's nothing wrong with having it in the readme on GitHub - though having the changelog in the readme is not that common, and scrolling down on the already long page is easy to miss, especially to someone who already looked at the RtD page and thinks they are the same (that happened to me). I generally look for a CHANGELOG.md file or similar in the repo, or a contents item in the docs, or in the GitHub releases (which it just recently started being mirrored in). Bottom of the readme is not at all where I'd expect it to be. A developer should be expected to be able to find things where they normally are in other projects. Not saying it has to move, but I would at least like it available somewhere in the docs. :) I also value linking back and forth - I always use the GitHub project URL to go to the docs (which is actually available in the API, which I didn't realize before! Off topic), and I use the link at the top right of the docs to go to the repo (edit this page, fork me, etc). It drops me in edit mode for some repos (like this one), but it's universal and a fast way to get to the GitHub without having to dig in RtD's menu or look for a link that is different in each project. And getting to the home page is one click away even if it is in edit mode. TLDR: Having two pages that start with the same content but then the one that is already longer (due to file list) has more information at the bottom is not very friendly. Especially when that content is only available there and not on the other site or in a commonly named file. |
creme -> river, and GMIC doesn't seem to use cibuildwheel anymore (moved to back up folder - custom speggetti mess of scripts (it might be that cibuildwheel was only being used for Windows, and the author gave up on Windows). This should be updated except for notes. Stars was there to make it easier to sort - but now we sort by stars anyway. :)
|
PS: the logos are a bit hard to see in GitHub: dark mode. https://github.blog/2020-12-08-new-from-universe-2020-dark-mode-github-sponsors-for-companies-and-more/ Opened issue here: https://github.community/t/uncolored-svg-should-be-white-in-dark-mode/147914 |
Co-authored-by: Matthieu Darbois <[email protected]>
Just noticed: if I wanted to be nitpicky, I'd say that |
I didn't want to put in in the main directory, and had no idea where else to put it. :) Happy to move it if someone has a better spot. |
Since we have no |
Hi @henryiii, I hope you don't mind I did a little work on this. I've added a few notes on the popular projects, but to be completely honest I got a little bored so didn't do it for all the projects 🙃. I see there's still an issue around dark mode for the icons, I'm wondering if something like |
Ah, good idea. I didn't want to inject the html into the table, so didn't have a solution for the sizing - vendored icons likely would work well. |
Hopefully mondeja/mkdocs-include-markdown-plugin#1 will provider a cleaner fix, but for now this works :)
See https://cibuildwheel--474.org.readthedocs.build/en/474/working-examples/ for how it now looks in the docs. I also added the changelog to the docs too. I'm pretty happy with where this is now, what do you think @henryiii ? |
LGTM! |
@joerick Don't think this is working as planned: https://cibuildwheel.readthedocs.io/en/latest/working-examples/ |
Oh that's weird! It was working in the PR. Oh, I guess the PR was in my vendored include plug-in and master is on the new broken-out one. Thanks for spotting this! I'll get a fix out tomorrow |
Adds a table, with a new stars column, and sorts by stars.