fix: support space in constraints file path #738
Conversation
|
For some reason this works on macOS but gives On windows. Does pip not understand URI's on Windows? |
|
Both types of quotes do not work. |
|
The best way to fix this would be to rely on pypa/pip#10116 when it becomes available, but for now, on Windows, we can make a temporary file if there is a space in the name, which is less likely to contain a space, I think. |
henryiii
changed the title
|
Could someone take a look at this? I think it will fix the bug with pip breaking build. |
henryiii
force-pushed
the
henryiii/fix/constraints
branch
from
32f7d0a to
b6a5968
Compare
|
@joerick Would it be possible to get another dev release after this to see if if fixes the problem I was seeing in the wild? |
|
Yep, sure! Let me have another look at this. |
|
I hope it's okay with you @henryiii, I just pushed a couple of tidy up commits. If that looks good to you, I should be able to get another alpha out today. |
| args: Sequence[PathOrStr], env: Optional[Dict[str, str]] = None, cwd: Optional[str] = None | ||
| args: Sequence[PathOrStr], env: Optional[Dict[str, str]] = None, cwd: Optional[PathOrStr] = None |
There was a problem hiding this comment.
Would have been nice with #672, would have fixed this for all OSs. :)
There was a problem hiding this comment.
haha! yeah... need to decide what to do with that...
cibuildwheel/windows.py
Outdated
| constr = options.dependency_constraints.get_for_python_version(config.version) | ||
| constraints_path = options.dependency_constraints.get_for_python_version( | ||
| config.version | ||
| ) |
There was a problem hiding this comment.
FYI, this originally was exactly the number of characters that kept this from wrapping. ;) This is fine, though.
Closes #740.