Skip to content

runtime: bump pkginfo to ~1.12 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

runtime: bump pkginfo to ~1.12 #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
135a7f4
runtime: bump pkginfo to ~1.12
woodruffw Dec 5, 2024
3f7b271
requirements: add twine PR ref
woodruffw Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions requirements/runtime.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
twine ~= 6.0

# NOTE: 1.12.0 and later enable support for metadata 2.4
# NOTE: This can be dropped once twine stops using pkginfo
# Ref: https://github.com/pypa/twine/pull/1180
pkginfo ~= 1.12.0
Comment on lines +3 to +6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer indirect deps to go into a dedicated constraint file… Though, since there are precedents of having them here, this request is out of the scope of this PR. It's something to address separately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I feel bad about this being here. The "good" news is that I can revert it pretty much immediately once it's locked, since pip won't downgrade it. But I don't know if that's better or worse 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woodruffw here's a pattern I came up with and started using in many places: https://github.com/ansible/awx-plugins/blob/e7d5733/dependencies/direct/py.in / https://github.com/ansible/awx-plugins/blob/e7d5733/dependencies/direct/py-constraints.in. Basically, any limitations, including transitive deps, are maintained in a separate file that does not contribute its entries to a list of "user install requests" but to "restrict if met during dependency resolution".


# NOTE: Used to detect an ambient OIDC credential for OIDC publishing,
# NOTE: as well as PEP 740 attestations.
id ~= 1.0
Expand Down
6 changes: 4 additions & 2 deletions requirements/runtime.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ packaging==24.1
# -r runtime.in
# pypi-attestations
# twine
pkginfo==1.10.0
# via twine
pkginfo==1.12.0
# via
# -r runtime.in
# twine
platformdirs==4.2.2
# via sigstore
pyasn1==0.6.0
Expand Down
Loading