Use PYPI_API_TOKEN instead of pypi_password as secret name in examples #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub secrets are customarily spelled in uppercase, and in PyPI terms we're dealing with API tokens here, not passwords.
webknjaz
approved these changes
Dec 13, 2020
There was a problem hiding this comment.
Thanks, @scop! It's a great idea!
The reason these were lowercase is that GitHub used to allow those and only in recent months they've started normalizing names to uppercase.
P.S. It'd also be useful to update https://github.com/pypa/packaging.python.org/blob/master/source/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows.rst
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub secrets are customarily spelled in uppercase, and in PyPI terms we're dealing with API tokens here, not passwords.
I think these tweaks make things slightly easier to follow, and decrease likelihood of actual PyPI passwords ending up in secrets when careless.