-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Import PEP 440 #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import PEP 440 #1340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just having this page here and linked correctly is such an improvement!
I assume it is mostly copy-paste from the PEPs, is that right? Great job in any case!
Yes. I recommend to look at the commits separately. The first just copies the PEP text as-is, the others contain the edits so you can see what I changed exactly.
Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't double-checked that the contents of the newly-created page actually matches PEP 440 in a 1:1 manner, and am trusting that @jeanas hasn't sneaked in a spec change here. :)
Thanks for merging, @pradyunsg!
Well, as I wrote above, you can review the commits separately if you want. The diffs after the first commit show the exact text changes. You will see that they're just trimming motivation sections and stuff like changing "this PEP" to "this specification". |
@jeanas Thank you so much! So many times I have wanted to send someone a link to the specification for version specifiers but felt bad about sending the link to the PEP(s). |
Please see PR #1373 for a follow-up to replace "PEP" with "specification". |
Relates to #1093.