Skip to content

Import PEP 440 #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Import PEP 440 #1340

merged 4 commits into from
Nov 8, 2023

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Nov 4, 2023

Relates to #1093.

@jeanas jeanas marked this pull request as draft November 4, 2023 11:34
Copy link
Contributor

@sinoroc sinoroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just having this page here and linked correctly is such an improvement!

I assume it is mostly copy-paste from the PEPs, is that right? Great job in any case!

@jeanas
Copy link
Contributor Author

jeanas commented Nov 4, 2023

I assume it is mostly copy-paste from the PEPs, is that right?

Yes. I recommend to look at the commits separately. The first just copies the PEP text as-is, the others contain the edits so you can see what I changed exactly.

Great job in any case!

Thanks :)

@jeanas jeanas marked this pull request as ready for review November 4, 2023 19:14
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't double-checked that the contents of the newly-created page actually matches PEP 440 in a 1:1 manner, and am trusting that @jeanas hasn't sneaked in a spec change here. :)

@pradyunsg pradyunsg added this pull request to the merge queue Nov 8, 2023
Merged via the queue into pypa:main with commit fc332d9 Nov 8, 2023
@jeanas jeanas deleted the pep440 branch November 8, 2023 15:22
@jeanas
Copy link
Contributor Author

jeanas commented Nov 8, 2023

Thanks for merging, @pradyunsg!

am trusting that @jeanas hasn't sneaked in a spec change here. :)

Well, as I wrote above, you can review the commits separately if you want. The diffs after the first commit show the exact text changes. You will see that they're just trimming motivation sections and stuff like changing "this PEP" to "this specification".

@sinoroc
Copy link
Contributor

sinoroc commented Nov 8, 2023

@jeanas Thank you so much! So many times I have wanted to send someone a link to the specification for version specifiers but felt bad about sending the link to the PEP(s).

@hugovk
Copy link
Contributor

hugovk commented Nov 9, 2023

Please see PR #1373 for a follow-up to replace "PEP" with "specification".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants