Skip to content

Update references in modernize-setup-py-project guide #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Dec 4, 2023

In parallel PRs, these references were added and the labels got renamed.

(CC @pradyunsg)


📚 Documentation preview 📚: https://python-packaging-user-guide--1433.org.readthedocs.build/en/1433/

In parallel PRs, these references were added and the labels got renamed.
Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chrysle chrysle added this pull request to the merge queue Dec 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2023
@jeanas
Copy link
Contributor Author

jeanas commented Dec 5, 2023

Looks like CI failed because of linkcheck not finding https://pypa.github.io/pipx/ . This was probably an intermittent error. Is there an easy way to retry it? (I suppose I can always amend and force push...)

@chrysle
Copy link
Contributor

chrysle commented Dec 5, 2023

Looks like Sphinx doesn't accept the redirect. I'm looking into making the linkchecker more stable, could you temporarily replace the link?

@jeanas
Copy link
Contributor Author

jeanas commented Dec 5, 2023

Let me see if I can do this from my phone, I'm not at a computer right now.

@jeanas
Copy link
Contributor Author

jeanas commented Dec 5, 2023

@chrysle Done, could you retry the merge? Thanks!

@chrysle chrysle added this pull request to the merge queue Dec 5, 2023
Merged via the queue into pypa:main with commit 51e8fa4 Dec 5, 2023
@jeanas jeanas deleted the upd-refs branch December 5, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants