Skip to content

guides: replace pep517 CLI usage with pypa/build #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2020

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Nov 20, 2020

See pypa/pyproject-hooks#91

Signed-off-by: Filipe Laíns [email protected]

@FFY00 FFY00 force-pushed the replace-pep517-cli branch from 9d3b10b to 32fb039 Compare November 20, 2020 17:39
--out-dir dist/
build
--sdist
--weel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, I assume?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ugh, sorry. I will fix it up when I get to the computer.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@FFY00 FFY00 force-pushed the replace-pep517-cli branch from abad790 to 208d121 Compare November 21, 2020 00:28
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@pradyunsg pradyunsg merged commit 079f4ec into pypa:master Nov 21, 2020
@pradyunsg
Copy link
Member

Great! Thanks! ^>^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants