-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add a flag to ignore stale build directories #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
in pip-1.4 the build dir is cleaned when what flags are you using? can you paste your command and output. separate from whether to add a flag, I do notice one big problem. when the PreviousBuild exception is raised, the clean still occurs in the finally block. that needs to be fixed. pip is being cautious, and then still deletes it anyway. : ( pip does have delete markers, but it's for the whole build dir, not package by package. we could delete the whole build dir upon finding a pre-existing package sub-dir, but that concerned me when I thought about this before. we could add package-level delete markers, but note that I really want to move away from these static build locations (and use mktempd) as part of #906. |
I think I know what may be happening. I'm guessing these are global installs and the build dir is something like only in pip-1.4 is there logic to add a delete marker to global build dirs, so if you have this dir already (which most people will), you won't have the delete marker, and the clean routine won't/can't do anything. so, in addition to fixing the problem above, I'm thinking about (with @dstufft ) changing the default build dir name so that pip-1.4 installs will lay down a new dir and build marker, and people won't struggle with this. |
Yup nice guess they were global. Thanks for addressing so quickly, I'll try to apply the patch and see how things go (though I hear you guys have a release coming up). |
I get
PreviousBuildDirError
s quite often now from just trying to press through installing a package while incrementally getting it to go further in its installation process.I certainly appreciate the new politeness here, but I think it'd be useful to have a flag to tell pip to ignore any build directories so that I don't have to keep cleaning up after pip each time I install.
The text was updated successfully, but these errors were encountered: