Skip to content

CPython 3.13.1 is breaking Windows CI #13104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ichard26 opened this issue Dec 6, 2024 · 1 comment · Fixed by #13105
Closed

CPython 3.13.1 is breaking Windows CI #13104

ichard26 opened this issue Dec 6, 2024 · 1 comment · Fixed by #13105
Labels
C: tests Testing and related things

Comments

@ichard26
Copy link
Member

ichard26 commented Dec 6, 2024

Windows 3.13 CI is failing again due to upstream changes in CPython:

FAILED tests/unit/test_collector.py::test_ensure_quoted_url[file:///T:/path/with spaces/-file://///T:/path/with%20spaces] - AssertionError: assert 'file://///T:...ith%20spaces/' == 'file://///T:...with%20spaces'
  
  - file://///T:/path/with%20spaces
  + file://///T:/path/with%20spaces/
  ?                                +
FAILED tests/unit/test_urls.py::test_path_to_url_win[\\\\unc\\as\\path-file:////unc/as/path] - AssertionError: assert 'file://unc/as/path' == 'file:////unc/as/path'
  
  - file:////unc/as/path
  ?      --
  + file://unc/as/path

Taking a look at the changelog for 3.13.1, these are all of the potential bugfixes implicated:

cc @matthewhughes934 you've fixed a similar class of issues earlier. Would you be interested in taking a look at this?

@ichard26 ichard26 added type: maintenance Related to Development and Maintenance Processes C: tests Testing and related things and removed type: maintenance Related to Development and Maintenance Processes labels Dec 6, 2024
@ichard26
Copy link
Member Author

ichard26 commented Dec 7, 2024

Ugh, alright. So, I think python/cpython#126208 and python/cpython#126214 are responsible for both failures respectively. They weren't merged at the same time so it's likely that there is a bugfix released where the UNC slash count change was made but not the trailing slash change. This makes rewriting the test cases to accommodate all of the various forms challenging.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: tests Testing and related things
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant