GH-126205: Fix conversion of UNC paths to file URIs #126208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File URIs for Windows UNC paths should begin with two slashes, not four.
barneygale
added
needs backport to 3.12
zooba
approved these changes
Oct 30, 2024
|
Thanks very much Steve! |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
barneygale
added
needs backport to 3.12
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2024
…26208) File URIs for Windows UNC paths should begin with two slashes, not four. (cherry picked from commit 951cb2c) Co-authored-by: Barney Gale <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2024
…26208) File URIs for Windows UNC paths should begin with two slashes, not four. (cherry picked from commit 951cb2c) Co-authored-by: Barney Gale <[email protected]>
|
GH-126248 is a backport of this pull request to the 3.12 branch. |
|
GH-126249 is a backport of this pull request to the 3.13 branch. |
barneygale
added a commit
that referenced
this pull request
Oct 31, 2024
#126249) GH-126205: Fix conversion of UNC paths to file URIs (GH-126208) File URIs for Windows UNC paths should begin with two slashes, not four. (cherry picked from commit 951cb2c) Co-authored-by: Barney Gale <[email protected]>
barneygale
added a commit
that referenced
this pull request
Oct 31, 2024
#126248) GH-126205: Fix conversion of UNC paths to file URIs (GH-126208) File URIs for Windows UNC paths should begin with two slashes, not four. (cherry picked from commit 951cb2c) Co-authored-by: Barney Gale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File URIs for Windows UNC paths should begin with two slashes, not four - see issue.