pip goes into infinite recursion due to recent commit

[eteq]

A package I work on (which uses the developer pip for wheels support) recently started failing, and I tracked the problem to a recent pip commit. If you look at https://travis-ci.org/eteq/astropy/jobs/7866383 you'll see a perfectly successful build. However, if you look at https://travis-ci.org/eteq/astropy/jobs/7866415 you'll see that the same build fails in pip with a complaint about infinite recursion. The only difference between these two is that the one that works is using the pip from be0c47f, while the failing one uses 8344fb8 . This clearly demonstrates that 8344fb8 is at fault, although I have no idea how.

Just ask if you want me to try anymore debugging!

[dstufft]

So this was a little interesting, the problem was that sourceforge has urls like http://sourceforge.net/projects/docutils/files/docutils/0.8.1/docutils-0.8.1.tar.gz/download which pip doesn't see as possibly non HTML so it doesn't bother doing a HEAD request and checking the content type. After we pass that check (without checking) pip just blindly assumes that the content it's getting is HTML and thus parseable.

So the fix was to, after we've fetched the url, inspect the headers and verify the content type.

[eteq]

Tricky - I guess the fact that it was erroring due to recursion was sort of a red herring then. Anyway, thanks for the quick fix!