Do a check prior to returning HTMLPage that it is indeed html #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously pip would check with a HEAD request if the url looked like it contained an archive and skip the file. However this didn't work if the url didn't look like an archive and instead just redirected to an archive. This will therefore, after the url has been fetched, inspect the headers and look to see if the Content-Type is text/html.
jezdez
added a commit
that referenced
this pull request
Jun 7, 2013
Do a check prior to returning HTMLPage that it is indeed html
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously pip would check with a HEAD request if the url looked
like it contained an archive and skip the file. However this didn't
work if the url didn't look like an archive and instead just
redirected to an archive.
This will therefore, after the url has been fetched, inspect the
headers and look to see if the Content-Type is text/html.
This fixes #983