Correctly normalize relative paths for 'pip show' #10206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
mypy isn't happy. |
This is passing against 21.1.3, but not main. The installed-files.txt test case is substentially rewritten to correctly test against a legacy setuptools installation.
Since the legacy installed-files.txt writes paths relatively to the egg-info directory, we need to introduce a new property on BaseDistribution to return that directory's path (analoguous to pkg_resources's Distribution.egg_info). Entries in RECORD are normalized with pathlib.Path so they have the correct path component separator depending on the platform (e.g. '/' on Windows), to match the previous behavior.
uranusjr
force-pushed
the
pip-show-files-paths
branch
from
21422d4 to
d0ce82a
Compare
uranusjr
force-pushed
the
pip-show-files-paths
branch
from
662f20a to
dd8a117
Compare
uranusjr
force-pushed
the
pip-show-files-paths
branch
from
8e61f41 to
3bf6c7c
Compare
|
@JAK0723 @mallamanis would be awesome if both of you could try this out with |
|
@uranusjr It seems to be working fine. |
|
Awesome! I’ll release 21.2.2 soon. |
uranusjr
changed the title
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10204. Fix #10231.
Since the legacy
installed-files.txtwrites paths relatively to the egg-info directory, we need to introduce a new property onBaseDistributionto return that directory's path (analoguous topkg_resources.Distribution.egg_info).Entries in RECORD are normalized with pathlib.Path so they have the correct path component separator depending on the platform (e.g.
/on Windows), to match the previous behavior.