Fix InstalledDistribution's metadata interface #10507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InstallRequirement.satisfied_by is an old-style distribution object (pkg_resources) for now, so we need to provide a shim for its access in InstalledDistribution.get_metadata_distribution(). Not sure why this was not picked up by the type checker :/
pradyunsg
reviewed
Sep 26, 2021
| @@ -0,0 +1,2 @@ | |||
| Fix a crash when installing an editable requirement using the legacy resolver | |||
There was a problem hiding this comment.
Did this ever make it into a release? If not, let’s drop this entry, since there’s no user facing behaviour changes here.
There was a problem hiding this comment.
Honestly I’m not sure when the breaking change was made, the refactoring dragged for quite a while.
There was a problem hiding this comment.
I filed #10523 to remove the news file, as the bug as not present in 21.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallRequirement.satisfied_byis an old-style distribution object (pkg_resources.Distribution) for now, so we need to provide a shim for its access inInstalledDistribution.get_metadata_distribution(). Not sure why this was not picked up by the type checker :/Fix #10504.