Fix documentation on when setup.py clean is run
#10536
Merged
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
the
skip news
sbidoul
reviewed
Oct 3, 2021
pradyunsg
force-pushed
the
docs/fix-wordin
branch
from
69915d2 to
04d3453
Compare
|
If there's no concerns with this one by Friday, I'll merge this then. I also won't mind if someone green ticks this and this gets merged sooner. :) |
DiddiLeija
approved these changes
Oct 18, 2021
|
@pradyunsg I've unresolved my comment as I still think the cleanup is done on build failure only. |
It is only run on failure to build wheels.
pradyunsg
force-pushed
the
docs/fix-wordin
branch
from
04d3453 to
b576329
Compare
|
Indeed. 😓 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured out while reading #5661.