-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Autosetuptools #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Autosetuptools #1069
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
11b1cf1
add pkg_resources from setuptools 0.9.6
dholth 20407b9
use relative import inside _markerlib
dholth cdf46f5
rewrite "import pkg_resoures" to "import pip.pkg_resources as
dholth d03ba3a
basic working "pip without setuptools"
dholth 59277b0
if setuptools is needed, automatically install and retry.
dholth 9e513d4
fix wheel installs by changing if back to elif
dholth e074c1f
show both 'install setuptools' and 'install wheel' errors for "pip
dholth a777d45
update tests to new wheel expectations
dholth 607a84a
enhanced __main__ to allow runnable wheel "python pip.whl/pip ..."
dholth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,15 @@ | ||
import sys | ||
from .runner import run | ||
|
||
if __name__ == '__main__': | ||
def main(): # needed for console script | ||
if __package__ == '': | ||
# To be able to run 'python pip.whl/pip': | ||
import os.path | ||
path = os.path.dirname(os.path.dirname(__file__)) | ||
sys.path[0:0] = [path] | ||
from pip.runner import run | ||
exit = run() | ||
if exit: | ||
sys.exit(exit) | ||
|
||
if __name__ == '__main__': | ||
main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
from pip.vendor.pkg_resources import * | ||
from pip.vendor.pkg_resources import PY_MAJOR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
try: | ||
import ast | ||
from .markers import default_environment, compile, interpret | ||
except ImportError: | ||
if 'ast' in globals(): | ||
raise | ||
def default_environment(): | ||
return {} | ||
def compile(marker): | ||
def marker_fn(environment=None, override=None): | ||
# 'empty markers are True' heuristic won't install extra deps. | ||
return not marker.strip() | ||
marker_fn.__doc__ = marker | ||
return marker_fn | ||
def interpret(marker, environment=None, override=None): | ||
return compile(marker)() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
# -*- coding: utf-8 -*- | ||
"""Interpret PEP 345 environment markers. | ||
|
||
EXPR [in|==|!=|not in] EXPR [or|and] ... | ||
|
||
where EXPR belongs to any of those: | ||
|
||
python_version = '%s.%s' % (sys.version_info[0], sys.version_info[1]) | ||
python_full_version = sys.version.split()[0] | ||
os.name = os.name | ||
sys.platform = sys.platform | ||
platform.version = platform.version() | ||
platform.machine = platform.machine() | ||
platform.python_implementation = platform.python_implementation() | ||
a free string, like '2.6', or 'win32' | ||
""" | ||
|
||
__all__ = ['default_environment', 'compile', 'interpret'] | ||
|
||
import ast | ||
import os | ||
import platform | ||
import sys | ||
import weakref | ||
|
||
_builtin_compile = compile | ||
|
||
try: | ||
from platform import python_implementation | ||
except ImportError: | ||
if os.name == "java": | ||
# Jython 2.5 has ast module, but not platform.python_implementation() function. | ||
def python_implementation(): | ||
return "Jython" | ||
else: | ||
raise | ||
|
||
|
||
# restricted set of variables | ||
_VARS = {'sys.platform': sys.platform, | ||
'python_version': '%s.%s' % sys.version_info[:2], | ||
# FIXME parsing sys.platform is not reliable, but there is no other | ||
# way to get e.g. 2.7.2+, and the PEP is defined with sys.version | ||
'python_full_version': sys.version.split(' ', 1)[0], | ||
'os.name': os.name, | ||
'platform.version': platform.version(), | ||
'platform.machine': platform.machine(), | ||
'platform.python_implementation': python_implementation(), | ||
'extra': None # wheel extension | ||
} | ||
|
||
def default_environment(): | ||
"""Return copy of default PEP 385 globals dictionary.""" | ||
return dict(_VARS) | ||
|
||
class ASTWhitelist(ast.NodeTransformer): | ||
def __init__(self, statement): | ||
self.statement = statement # for error messages | ||
|
||
ALLOWED = (ast.Compare, ast.BoolOp, ast.Attribute, ast.Name, ast.Load, ast.Str) | ||
# Bool operations | ||
ALLOWED += (ast.And, ast.Or) | ||
# Comparison operations | ||
ALLOWED += (ast.Eq, ast.Gt, ast.GtE, ast.In, ast.Is, ast.IsNot, ast.Lt, ast.LtE, ast.NotEq, ast.NotIn) | ||
|
||
def visit(self, node): | ||
"""Ensure statement only contains allowed nodes.""" | ||
if not isinstance(node, self.ALLOWED): | ||
raise SyntaxError('Not allowed in environment markers.\n%s\n%s' % | ||
(self.statement, | ||
(' ' * node.col_offset) + '^')) | ||
return ast.NodeTransformer.visit(self, node) | ||
|
||
def visit_Attribute(self, node): | ||
"""Flatten one level of attribute access.""" | ||
new_node = ast.Name("%s.%s" % (node.value.id, node.attr), node.ctx) | ||
return ast.copy_location(new_node, node) | ||
|
||
def parse_marker(marker): | ||
tree = ast.parse(marker, mode='eval') | ||
new_tree = ASTWhitelist(marker).generic_visit(tree) | ||
return new_tree | ||
|
||
def compile_marker(parsed_marker): | ||
return _builtin_compile(parsed_marker, '<environment marker>', 'eval', | ||
dont_inherit=True) | ||
|
||
_cache = weakref.WeakValueDictionary() | ||
|
||
def compile(marker): | ||
"""Return compiled marker as a function accepting an environment dict.""" | ||
try: | ||
return _cache[marker] | ||
except KeyError: | ||
pass | ||
if not marker.strip(): | ||
def marker_fn(environment=None, override=None): | ||
"""""" | ||
return True | ||
else: | ||
compiled_marker = compile_marker(parse_marker(marker)) | ||
def marker_fn(environment=None, override=None): | ||
"""override updates environment""" | ||
if override is None: | ||
override = {} | ||
if environment is None: | ||
environment = default_environment() | ||
environment.update(override) | ||
return eval(compiled_marker, environment) | ||
marker_fn.__doc__ = marker | ||
_cache[marker] = marker_fn | ||
return _cache[marker] | ||
|
||
def interpret(marker, environment=None): | ||
return compile(marker)(environment) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think each pip version should set a setuptools requirement (based on our testing), not just "setuptools"
If setuptools is installed and doesn't meet the requirement, I think we should prompt them for what they want to do. "Proceed at risk, or Allow pip to re-install". they could set the permanent answer in their config or environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea and would help me; I'm always getting older versions of setuptools by accident.
Except -1 on the interactive prompt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case where we'd be upgrading, not sure we can just presume. they're just trying to install some package, and we go upgrade setuptools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer to exit with an error code and something like a "please upgrade setuptools or use --force" message if setuptools is installed but too old. We'll get there when we get there.