Skip to content

Skip conditional build req without matching marker #11030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2022
Merged

Skip conditional build req without matching marker #11030

merged 1 commit into from
Apr 16, 2022

Conversation

uranusjr
Copy link
Member

Fix #10883.

pradyunsg
pradyunsg requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test for this.

@uranusjr uranusjr force-pushed the build-env-req-check-evaluate-marker branch from 6b684c2 to c01388d Compare April 13, 2022 09:24
@uranusjr
Copy link
Member Author

Added!

@pradyunsg
Copy link
Member

And... you need to pacify the linters! :)

@uranusjr uranusjr force-pushed the build-env-req-check-evaluate-marker branch from c01388d to 233db7c Compare April 16, 2022 08:02
@uranusjr uranusjr merged commit 8133d83 into pypa:main Apr 16, 2022
@uranusjr uranusjr deleted the build-env-req-check-evaluate-marker branch April 16, 2022 11:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup_requires with python_version conflicts with identical pyproject.toml build-system.requires
2 participants
@uranusjr @pradyunsg