Skip to content

Convert to str shutil.move src arg for py<=39 #11190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2022
Merged

Convert to str shutil.move src arg for py<=39 #11190

merged 2 commits into from
Jun 23, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Jun 15, 2022 •
edited
Loading

python/cpython#76870
The alternative solution is to check if dst is dir, but mypy would fail.

@q0w q0w force-pushed the fix-venv-move branch from aa7f270 to 3181063 Compare June 15, 2022 19:07
uranusjr
uranusjr reviewed Jun 21, 2022
View reviewed changes
uranusjr
uranusjr reviewed Jun 21, 2022
View reviewed changes
@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jun 21, 2022
@sbidoul sbidoul merged commit 1a46eed into pypa:main Jun 23, 2022
@q0w q0w deleted the fix-venv-move branch June 23, 2022 19:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@q0w @uranusjr @sbidoul