-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add an interface to allow calling system keyring
#11589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b87ddb9
Add an interface to allow calling system `keyring`
judahrand edc588c
Add news
judahrand 4cbae5b
Improve cli interface
judahrand efa7f2b
Raise better exception
judahrand 7e93102
Don't capture output
judahrand 6ec0af5
Handle IO encoding
judahrand f5c96b1
Switch to defining `get_password`
judahrand 43abcf0
Set `keyring` correctly
judahrand 5137ce2
Use full `keyring` path
judahrand 4fc2008
Prevent `keyring` from ever reading from `stdin`
judahrand 888c3b6
Abstract provider interface to `keyring`
judahrand 996d4fa
Take copy of `os.environ` rather than editing
judahrand 4f8a613
Import `keyring` lazily
judahrand 3a15e01
Get the tests passing again
judahrand 8d9ea8b
Add tests for new code paths
judahrand c04222f
Simplify provider interface
judahrand e6e42de
Move `keyring` import
judahrand 14a3d93
Don't silently fallback to cli
judahrand 623ac5d
Do fallback but issue a warning
judahrand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Enable the use of ``keyring`` found on ``PATH``. This allows ``keyring`` | ||
installed using ``pipx`` to be used by ``pip``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.