Log ending round state @ during resolver debug #12264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(not sure if this is worthy of a change note) |
webknjaz
added
type: bug
|
This is not a typo -- encoding the entire state into the message was deemed not useful and causes a lot of noise when extremely long resolves take place. |
|
@pradyunsg should it be logged with DEBUG level instead of INFO, then? It's probably useful in some cases. |
uranusjr
previously approved these changes
Sep 7, 2023
uranusjr
dismissed
their stale review
DEBUG or VERBOSE would make sense (maybe DEBUG)
|
DEBUG works. :) |
webknjaz
force-pushed
the
bugfixes/resolvelib-debugging-reporter-ending-round-state
branch
from
62fae81 to
8b63fe6
Compare
webknjaz
commented
Jan 17, 2024
|
@pradyunsg do you think this needs a change note? |
|
Personally I think this is fine, an additional log shouldn’t break things (you’re doing somethign wrong if it does…) |
uranusjr
added
the
skip news
uranusjr
approved these changes
Mar 26, 2024
|
@pradyunsg it should be easy to merge this? |
This change corrects a tiny-little mistake made in 9f318de that was causing the word "state" to be printed out in the log instead of the value of the `ending_round()`'s state` argument.
webknjaz
force-pushed
the
bugfixes/resolvelib-debugging-reporter-ending-round-state
branch
from
8b63fe6 to
ea5f26e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects a tiny-little mistake made in 9f318de that was causing the word "state" to be printed out in the log instead of the value of the
ending_round()'s state` argument.