Remove import re from script template
#13166
Conversation
|
While I would personally prefer the distlib script to contain the minimal number of imports, I am against diverging from distlibs default in pip. If distlib maintainers don't want to take on the burden of this putting that burden on to pip has all the same problems and more, pip is not running distlib's test suite, does not have distlib's expertise, and could fall out of sync with changes in distlib. And this would affect a huge number of users. I'll say -0, because it is actually fairly simple, and maybe some other maintainer is enthusiastic to support this. |
|
Added some code review comments, but see my comment on #13165 for my broader views. |
I am! |
| @@ -412,6 +412,16 @@ def _raise_for_invalid_entrypoint(specification: str) -> None: | |||
|
|
|||
|
|
|||
| class PipScriptMaker(ScriptMaker): | |||
| # Override distlib's default script template with one that | |||
| # doesn't import `re` module, allowing scripts to load faster. | |||
| script_template = r"""import sys | |||
There was a problem hiding this comment.
nit: I'd prefer we do a textwrap.dedent for this template, just to make it easier to work with non-syntax aware collapses (and align the visual hierarchy).
Overrides
distlib.scripts.ScripMaker.script_templatewith a template that doesn'timport re.Closes #13165