Proposed fix to #1180 - Make 'pip search' support http proxy #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make use of `proxy` option in `search` command. * Add a new `UrllibTransport` class for `xmlrpclib.ServerProxy` to support http proxy based upon `urllib` (Py3) / `urllib2` (Py2).
|
It probably makes more sense to have this use requests like the rest of pip does yea? |
|
Oops... absolutely. I'll to rewrite Thanks for your feedback! |
|
Hi all, To aims of clarity, I'll put here a reference to the pull request #1902 with my propose of a Regards. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is my two cents trying to fix the unsupported --proxy option for the search command. Following changes have been made:
--proxyoption insearchcommand.UrllibTransportclass forxmlrpclib.ServerProxyto support http proxy based uponurllib(Py3) /urllib2(Py2).