Separate pip freeze command from operation #2173
Conversation
|
Fixing merge conflict (conflicts with 5b817f9)... |
msabramo
force-pushed
the
extract_freeze_operation
branch
from
b9a6ad7 to
8954e29
Compare
|
Fixed merge conflict with rebase to 8954e29. |
|
Hmmm, Travis CI is going to fail, because the PyPy run ran out of disk space, which I am presuming is a Travis CI issue. |
|
Someone want to restart https://travis-ci.org/pypa/pip/builds/43854252 ? |
|
Done |
|
The idea of extracting the logic from commands is good. pip wheel, pip list or pip install could also benefit from such refactoring. |
|
@xavfernandez: Yeah I would also propose to do the same with other commands of course, though my thought was to do them in separate PRs. The reason for this is that changing a command like this is a big change so it's very easy for some other change to make the PR have merge conflicts. This is less likely to happen if I keep each PR focused on one command. |
|
If we're going to do this, it'd probably be better to make |
|
I could rename What do you think? |
|
Yea that sounds like a good path forward. |
msabramo
force-pushed
the
extract_freeze_operation
branch
from
8954e29 to
ef11ca9
Compare
|
OK, rebased and updated to ef11ca9. |
By extracting the logic into pip.operations.freeze, the hope is that folks could do a freeze programmatically more easily.
msabramo
force-pushed
the
extract_freeze_operation
branch
from
ef11ca9 to
0711744
Compare
|
Updated to fix |
Separate pip freeze command from operation
|
Interesting, I found a first example of someone using https://github.com/marksteve/pip-pin/blob/master/pip_pin.py#L3 |
By extracting the logic into pip.operations.list, the hope is that folks could do a list programmatically more easily. Continuing work started in pypa#2173
By extracting the logic into `pip.operations.search`, the hope is that folks could do a `search` programmatically more easily. It also has greater separation of concerns and should allow people to work in parallel with less chance of merge conflicts. Continuing work started in pypa#2173 and pypa#2404.
By extracting the logic into `pip.operations.search`, the hope is that folks could do a `search` programmatically more easily. It also has greater separation of concerns and should allow people to work in parallel with less chance of merge conflicts. Continuing work started in pypa#2173 and pypa#2404.
By extracting the logic into `pip.operations.search`, the hope is that folks could do a `search` programmatically more easily. It also has greater separation of concerns and should allow people to work in parallel with less chance of merge conflicts. Continuing work started in pypa#2173 and pypa#2404.
By extracting the logic into `pip.operations.wheel`, the hope is that folks could do a `wheel` programmatically more easily. It also has greater separation of concerns and should allow people to work in parallel with less chance of merge conflicts. Continuing work started in pypa#2173, pypa#2404, and pypa#2410.
By extracting the logic into `pip.operations.search`, the hope is that folks could do a `search` programmatically more easily. It also has greater separation of concerns and should allow people to work in parallel with less chance of merge conflicts. Continuing work started in pypa#2173 and pypa#2404.
By extracting the logic into `pip.operations.search`, the hope is that folks could do a `search` programmatically more easily. It also has greater separation of concerns and should allow people to work in parallel with less chance of merge conflicts. Continuing work started in pypa#2173 and pypa#2404.
lock
bot
added
the
auto-locked
By extracting the logic into
pip.operations.freeze, the hope is that folks could do a freeze programmatically more easily.Inspired by #2150