Make test_freeze_bazaar_clone not depend on bazaar.launchpad.net #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'bzr', 'commit', '-q', | ||
| '--author', 'pip <[email protected]>', | ||
| '-m', 'initial version', cwd=version_pkg_path, | ||
| ) |
There was a problem hiding this comment.
One could add an else clause raising ValueError('Unknown vcs: %r' % vcs)
msabramo
force-pushed
the
test_freeze_remove_dep_on_launchpad
branch
2 times, most recently
from
2842d2d to
682c78f
Compare
|
OK, I think I handled all of the issues raised by @pfmoore and @xavfernandez. I guess it can be rereviewed and possibly merged if Travis CI passes. |
msabramo
force-pushed
the
test_freeze_remove_dep_on_launchpad
branch
2 times, most recently
from
8c102e8 to
cbf4687
Compare
|
Added a note to |
msabramo
force-pushed
the
test_freeze_remove_dep_on_launchpad
branch
from
cbf4687 to
782e251
Compare
|
Travis CI passed |
|
Merge conflicts from the other PRs that were merged. Will fix... |
msabramo
force-pushed
the
test_freeze_remove_dep_on_launchpad
branch
from
782e251 to
7f5566f
Compare
|
Merge conflicts fixed. |
|
I'll merge once Travis builds succeed (assuming Travis haven't blacklisted us for melting their servers ;-)) |
pfmoore
added a commit
that referenced
this pull request
Mar 11, 2015
…chpad Make test_freeze_bazaar_clone not depend on bazaar.launchpad.net
This was referenced Mar 12, 2015
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking out bzr+http://bazaar.launchpad.net/%7Edjango-wikiapp/django-wikiapp/, we create a bzr repo on the fly by calling
tests.lib._create_test_packagewhich has been enhanced to be able to create bzr repos:The test is no longer marked as
network(because it doesn't require the network -- yay!), but it is markedbzr. This allows for skipping the test in environments wherebzris not installed -- e.g.: