Skip to content

Document PEP 518 support #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2018
Merged

Document PEP 518 support #5065

merged 1 commit into from
Mar 19, 2018

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Mar 14, 2018

Addresses #4803

@pfmoore pfmoore added the skip news Does not need a NEWS file entry (eg: trivial changes) label Mar 14, 2018
@pfmoore pfmoore requested a review from pradyunsg March 14, 2018 10:07
pradyunsg
pradyunsg reviewed Mar 18, 2018
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • Might need a line stating that PEP 518 dependencies might not install with the same behaviour as pip installing the same requirements.

@pfmoore
Copy link
Member Author

pfmoore commented Mar 18, 2018

Might need a line stating that PEP 518 dependencies might not install with the same behaviour as pip installing the same requirements.

Why wouldn't they?

@pradyunsg
Copy link
Member

They won't. I am gonna say that was a lack of sleep.

This PR is good to go.

@pfmoore pfmoore merged commit 277bd6b into pypa:master Mar 19, 2018
@pfmoore pfmoore deleted the pep518-docs branch March 19, 2018 17:37
@pfmoore pfmoore mentioned this pull request Mar 20, 2018
Closed
@astrojuanlu
Copy link
Contributor

Thanks for describing it so clearly for the users 🎉

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfmoore @pradyunsg @astrojuanlu