-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Re-install PEP 508 wheel dependencies when the version changes #6402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5348d6f
Re-install PEP 508 dependencies when the URL changes
benoit-pierre 1bebc53
Add tests for #5780
rouge8 d6d5472
News fragments
rouge8 d938a8e
Fixes for existing tests
rouge8 51d6ab7
Fix news fragments
rouge8 a63ca36
Rework tests to use local wheels not require network access
rouge8 f7cdf3b
Pass use_pep517 along
rouge8 2116c04
PR feedback and tests
rouge8 251a002
Split the test into two tests
rouge8 caf1d65
Allow extra in re-install PEP 508 dependencies when the URL changes
lmarvaud a4a121a
Lint
rouge8 e3e359c
Fix existing tests
rouge8 3a5f27a
Add test for extras
rouge8 c348730
Rebase and remove bad options
rouge8 31c1f4f
Test fixes
rouge8 2e082f9
Limit support for directories as PEP508 dependencies
rouge8 e5bcc32
mypy fix
rouge8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Re-install PEP 508 dependencies when the URL changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Re-install PEP 508 dependencies when the URL changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -434,6 +434,21 @@ def install_req_from_req_string( | |
"{} depends on {} ".format(comes_from.name, req) | ||
) | ||
|
||
if req.url: | ||
# Create an InstallRequirement for a wheel-like PEP 508 URL with the | ||
# same behavior as 'pip install req.url' | ||
parts = parse_req_from_line(req.url, None) | ||
link = Link(req.url) | ||
if link.is_wheel: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
return InstallRequirement( | ||
parts.requirement, | ||
comes_from=comes_from, | ||
link=parts.link, | ||
markers=parts.markers, | ||
use_pep517=use_pep517, | ||
isolated=isolated, | ||
extras=req.extras, | ||
) | ||
return InstallRequirement( | ||
req, comes_from, isolated=isolated, use_pep517=use_pep517 | ||
) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.