Skip to content

Remove unused incompatible functions from tests.lib.Path. #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Remove unused incompatible functions from tests.lib.Path. #6665

merged 1 commit into from
Jul 1, 2019

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Jul 1, 2019

Several functions in tests.lib.Path do not have direct analogues in pathlib.Path, but fortunately we don't use them. Makes some progress on #6050.

pradyunsg
pradyunsg approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing untested test helpers! 10/10

Thanks for picking this up!

@xavfernandez xavfernandez merged commit ec73d72 into pypa:master Jul 1, 2019
@xavfernandez
Copy link
Member

Thanks @chrahunt

@chrahunt chrahunt deleted the pathlib-refactor-1 branch July 1, 2019 11:19
@chrahunt chrahunt mentioned this pull request Jul 3, 2019
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrahunt @xavfernandez @pradyunsg