Rename compatible functions in tests.lib.path.Path. #6670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - Linters aren't happy. Thanks again for picking this up. :) |
chrahunt
force-pushed
the
pathlib-refactor-2
branch
from
db70c31 to
39ac9ca
Compare
Closed
|
Updated - linters are OK (but still disappointed). |
xavfernandez
approved these changes
Jul 3, 2019
|
I haven't reviewed every line but a skim seems like this does the right thing and @xavfernandez approved already, so going ahead and merging this. :) |
|
Hurrah! Thanks for this PR @chrahunt! |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work for #6050. Several methods in our
tests.lib.path.Pathclass have direct counterparts inpathlib.Path. In preparation for substitutingpathlib.Path, this renames the methods/properties according to the following:namebase->stemext->suffixfolder->parentexists->exists()remove()->unlink()rm()->unlink()join()->joinpath()write()->write_text()To remove any possibility of accidental usage of
str.join(), a method has been added toPaththat raises an exception. This can be removed after removing the inheritance fromstr.