Move LinkCollector to a new collector.py module #7016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
C: finder
cjerdonek
force-pushed
the
add-collector-module
branch
3 times, most recently
from
b836fc8 to
10de3ab
Compare
cjerdonek
force-pushed
the
add-collector-module
branch
from
10de3ab to
fe2509b
Compare
pradyunsg
approved these changes
Sep 14, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
LinkCollectorfromindex.pyto a new module calledcollector.py. This reduces the size ofindex.pyfrom 1496 lines to 1006 lines. It also further decouples the "link evaluation" code from the network / link-collecting stage. In particular, I believe this now makesindex.py"sans I/O." Even more can be done to separate the network / IO code from the rest ofcollector.py(e.g. the HTML parsing code).While this PR has many lines, it's just moving functions and classes (and the corresponding test methods) with no code changes, aside from things like updating import statements.