refactor should_use_ephemeral_cache #7262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
force-pushed
the
refactor-should_use_ephem_cache-sbi
branch
from
34148bf to
283eb23
Compare
chrahunt
added
skip news
chrahunt
reviewed
Oct 27, 2019
sbidoul
force-pushed
the
refactor-should_use_ephem_cache-sbi
branch
from
283eb23 to
e638e24
Compare
xavfernandez
approved these changes
Oct 28, 2019
|
Thanks @sbidoul! To answer your question about news files - a |
|
Thanks @chrahunt and @xavfernandez for the swift review and merge. I continue in #7268. |
4 tasks
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #6852
Following @chrahunt advice that no PR is small enough, I start with this refactoring of
should_use_ephemeral_cacheintoshould_buildandshould_cache. The new functions have independent tests. Next step will be to removeshould_use_ephemeral_cache.It's not exactly tiny, but it should hopefully be easy to understand.
I think all review comments from #6853 have been handled, including a #6853 (comment) (in a separate commit).
I have one question: which kind of newsfragment file should I create for a refactor like this?