Skip to content

Move _clean_zip_name into a nested function #7284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2019
Merged

Move _clean_zip_name into a nested function #7284

merged 1 commit into from
Nov 2, 2019

Conversation

pradyunsg
Copy link
Member

Why: Better models how it's used

@pradyunsg
Move _clean_zip_name into a nested function
7256207 
Why: Better models how it's used
@pradyunsg pradyunsg added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Nov 2, 2019
chrahunt
chrahunt approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would inline the function since IMO the name/param names aren't adding much value, but don't feel strongly about it.

@pradyunsg
Copy link
Member Author

Yea, me neither. I'll merge this since it's still an improvement over status quo.

@pradyunsg pradyunsg merged commit 799596e into pypa:master Nov 2, 2019
@pradyunsg pradyunsg deleted the refactor/_clean_zip_name branch November 2, 2019 17:05
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrahunt chrahunt chrahunt approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyunsg @chrahunt