Skip to content

Sort applicable candidates before computing best candidate #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2019
Merged

Sort applicable candidates before computing best candidate #7332

merged 2 commits into from
Nov 11, 2019

Conversation

pradyunsg
Copy link
Member

Toward #7317

@pradyunsg pradyunsg added type: enhancement Improvements to functionality C: finder PackageFinder and index related code skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code and removed type: enhancement Improvements to functionality labels Nov 10, 2019
@pradyunsg pradyunsg force-pushed the refactor/get-sorted-applicable-candidates branch from 6ff7897 to 997db00 Compare November 10, 2019 08:46
@pradyunsg
Copy link
Member Author

pradyunsg commented Nov 11, 2019 •
edited
Loading

I'll merge this in 24 ~10 hours unless someone flags concerns here. :)

chrahunt
chrahunt approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming most preferred is last to match the resolvelib AbstractProvider.find_matches ordering requirement?

@pradyunsg
Copy link
Member Author

I'm assuming most preferred is last to match the resolvelib AbstractProvider.find_matches ordering requirement?

Yep.

@pradyunsg pradyunsg merged commit 6c04fef into pypa:master Nov 11, 2019
@pradyunsg pradyunsg deleted the refactor/get-sorted-applicable-candidates branch November 11, 2019 16:41
@pradyunsg pradyunsg mentioned this pull request Nov 12, 2019
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrahunt chrahunt chrahunt approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: finder PackageFinder and index related code skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyunsg @chrahunt