Fix cache bug with legacy cache entries #7490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
force-pushed
the
legacy-cache-bug-sbi
branch
2 times, most recently
from
7d781c3 to
b92914a
Compare
sbidoul
force-pushed
the
legacy-cache-bug-sbi
branch
from
b92914a to
7b998a7
Compare
sbidoul
force-pushed
the
legacy-cache-bug-sbi
branch
from
7b998a7 to
36ff884
Compare
xavfernandez
approved these changes
Dec 16, 2019
| (wheel.support_index_min(supported_tags), wheel_name) | ||
| ( | ||
| wheel.support_index_min(supported_tags), | ||
| wheel_name, |
There was a problem hiding this comment.
nitpick: it's unlikely that the min() call would depend on the wheel_name.
There was a problem hiding this comment.
At least this is equivalent to the previous behavior. Alternatively, we may want to separately consider whether an sdist may produce a wheel with "build tag" that should be taken into account even in the cache.
xavfernandez
approved these changes
Dec 18, 2019
chrahunt
approved these changes
Dec 21, 2019
|
Merging since this has multiple approving reviews. |
|
Thanks |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an unreleased bug from #7319, in the handling of legacy cache entries.
The bug manifests itself when only a legacy cache entry exist for a given link, in which case pip would error like this:
This is because
_get_candidatesreturned cached wheel names and not their cache directory, with the cache directory later being reconstructed in_link_for_candidate. I fix this by returning awheel_name, wheel_dirtuple so callers do not need to do any guesswork to find the directory.